From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeff Davis <list-pgsql-hackers(at)dynworks(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: A couple items on TODO |
Date: | 2001-08-23 16:46:18 |
Message-ID: | 200108231646.f7NGkI915986@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> AFAIR, elog at NOTICE or DEBUG level isn't really supposed to have any
> side-effects. The bigger issue is that you have to be careful about
> using it in certain places, mainly during startup or for reporting
> communication errors. (send failure -> elog -> tries to send message to
> client -> send failure -> elog -> trouble)
>
> Also, I believe most of the printf's in the backend are in debugging
> support code that's not even compiled by default. The return on
> investment from converting those routines to use elog is really nil.
> There may be a few remaining printf calls that should be converted to
> elog, but I don't think this is a big issue.
Clearly not a big issue, but something someone can poke around at to get
started.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-08-23 17:00:00 | Re: Re: [HACKERS] Re: WIN32 errno patch |
Previous Message | Tom Lane | 2001-08-23 16:29:55 | Re: OLAP, Aggregates, and order of operations |