| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Neil Padgett <npadgett(at)redhat(dot)com>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, "'Fernando Nasser'" <fnasser(at)cygnus(dot)com>, pgsql-patches(at)postgreSQL(dot)org |
| Subject: | Re: Patch for Improved Syntax Error Reporting |
| Date: | 2001-08-03 15:53:53 |
| Message-ID: | 200108031553.f73Frrw27305@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Seems we could easily have the backend return a string with three tokens
> > before/after the syntax error, and that would be enough.
>
> I strongly disagree. If the "three tokens" are something like ")))",
> how's that going to help you figure out where you tanked your
> parenthesization in a huge query with dozens of parentheses? See also
> the points I made concerning errors masked by comment removal.
I strongly disagree too. :-) (See, I can use the word "strongly" too.)
Anyway, you aren't going to have three parens on both sides of the
error, are you? I didn't say it was perfect, just easier for the client
coders.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-08-03 16:17:39 | Re: Full Text Indexing Patch |
| Previous Message | Tom Lane | 2001-08-03 14:31:30 | Re: Patch for Improved Syntax Error Reporting |