> On Fri, 20 Jul 2001, Peter Eisentraut wrote:
>
> > Reinhard Max writes:
> >
> > > OK, I'll pack the new stuff inside #ifdef TCL_UTF8 and define that if
> > > the Tcl version is 8.1 or greater.
> >
> > No, please add a configure check for Tcl_UtfToExternalDString or
> > some other function representative of this interface..
>
> Why make simple things complicated?
> Tcl changed it's internal string representation starting with release
> 8.1 . It is not an interface one can decide whether to use it or not.
> Every extension that imports or exports strings and gets compiled for
> Tcl >= 8.1 has to make sure that they are UTF8 regardless, if it uses
> the Tcl_*Utf*DString functions or something else. So I consider it
> sufficient to define TCL_UTF8 if Tcl's Version is >= 8.1 as I did in
> the patch that was attached to my last mail.
I think he is OK checking the TCL version. It is pretty common to check
the TCL include file for symbols and handle things that way. Do we test
any other TCL include defines from configure?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026