From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Bruce Momjian - CVS <momjian(at)hub(dot)org>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql/src/bin/pg_ctl pg_ctl.sh |
Date: | 2001-07-11 19:17:03 |
Message-ID: | 200107111917.f6BJH3m27876@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
> Bruce Momjian - CVS writes:
>
> > CVSROOT: /home/projects/pgsql/cvsroot
> > Module name: pgsql
> > Changes by: momjian(at)hub(dot)org 01/07/11 12:16:53
> >
> > Modified files:
> > src/bin/pg_ctl : pg_ctl.sh
> >
> > Log message:
> > Move export PGDATA to the proper place.
>
> This is completely broken. The old place was right.
Can you explain. Do we not want to export PGDATA for other programs we
run from this script?
> > Quote some variable substitutions.
>
> You don't need to quote the argument to 'case'. Please don't do that, it
> makes things less readable.
Well, I guess. I usually quote all variable mentions. I saw lots of
VAR=$1 which should be VAR="$1", right?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2001-07-11 19:20:13 | Re: pgsql/src/bin/pg_ctl pg_ctl.sh |
Previous Message | Peter Eisentraut | 2001-07-11 19:12:15 | Re: pgsql/src/bin/pg_ctl pg_ctl.sh |