Re: [PATCH] Partial indicies again

On Tue, Jul 10, 2001 at 04:47:49PM +0200, Peter Eisentraut wrote:
> Martijn van Oosterhout writes:
>
> > Well, getting closer. Maybe I should start version numbering the patches?
>
> For one thing, you might want to post them to pgsql-patches instead. And
> you should start generating the patches against the 7.2devel sources
> because I already suspect yours generating conflicts.

Well, Tom Lane certainly keeps pointing out problems with it. I'm pulling
out the latest CVS to see if there are going to be any problems there.

> > * Updates to the documentation as well as comments within the code. If you
> > see a spot I missed, let me know.
>
> FYI, it's called partial "indexes".

Actually, it seems to depend on who you ask. Both spellings are scattered
throughout the documentation and the source. According to my dictionary,
both spellings are allowed.

> > * Make it pg_dump-able. I've tried to extract the expression out the of
> > system tables by using stringToNode and deparse_expression but it doesn't
> > seem to work. I keep getting the error: "get_names_for_var: bogus
> > varlevelsup 0". Anyone know what's going on? See attachment <<expr.c>>.
>
> It might be an option to store the unparsed condition in the system
> catalogs, similar to what is done with the default values (see
> pg_attrdef).

See my later email. This has been fixed already.

--
Martijn van Oosterhout <kleptog(at)svana(dot)org>
http://svana.org/kleptog/
> It would be nice if someone came up with a certification system that
> actually separated those who can barely regurgitate what they crammed over
> the last few weeks from those who command secret ninja networking powers.