Re: [PATCH] by request: base64 for bytea

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Alex Pilosov <alex(at)pilosoft(dot)com>
Cc: Marko Kreen <marko(at)l-t(dot)ee>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] by request: base64 for bytea
Date: 2001-06-23 13:48:18
Message-ID: 200106231348.f5NDmIX03349@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Sat, 23 Jun 2001, Marko Kreen wrote:
>
> > On Fri, Jun 22, 2001 at 09:55:46PM -0400, Bruce Momjian wrote:
> > > Your patch has been added to the PostgreSQL unapplied patches list at:
> >
> > > > Attached is a patch (including documentation this time :) containing two
> > > > functions, base64_encode(bytea) and base64_decode(text) with obvious
> > > > functionality.
> >
> > Btw, there are functions in form encode(data, 'base64'),
> > decode(data, 'base64') in contrib/pgcrypto. They do also
> > encode(data, 'hex'). In the future I need to do probably
> > encode(data, 'pgp-armor') too...
> >
> > I agree those functionality should be in core code, and if
> > the Alex ones get there, maybe he could use same interface?
> Oy, I didn't notice them in contrib/pgcrypt.
>
> Bruce, you can take my patch out of queue, stuff in pgcrypt is far more
> comprehensive than what I done.

Sure. Done. Funny we didn't need them as much for crypto but we do
need them for binary insertion into the database.

>
> > Or I can extract it out from pgcrypto and submit to core ;)
> > I simply had not a need for it because I used those with
> > pgcrypto, but Alex seems to hint that there would be bit of
> > interest otherwise too.
> I think encode/decode should be part of core, as they are basic functions
> to manipulate bytea data...

Agreed.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-06-23 13:49:24 Re: [PATCH] by request: base64 for bytea
Previous Message Marko Kreen 2001-06-23 13:43:33 Re: [PATCH] by request: base64 for bytea