Re: Python (PyGreSQL) make install patch

Peter,

On Fri, Jun 22, 2001 at 08:39:28PM +0200, Peter Eisentraut wrote:
> [The updated proposed new makefile for interfaces/python is attached.]

I was just about to ping you to see if you were available to continue
working is this stuff -- thanks for getting back to me.

> > See attached for patches that are necessary for Cygwin.
>
> > @@ -13,7 +13,7 @@ include $(top_srcdir)/src/Makefile.shlib
> > override CFLAGS += $(CFLAGS_SL)
> > # (Python also has a config.h file. Be sure to use ours.)
> > override CPPFLAGS := -I$(libpq_srcdir) $(CPPFLAGS) -I$(python_includedir)
> > -SHLIB_LINK = $(libpq)
> > +SHLIB_LINK = $(libpq) $(python_libspec)
> >
> > all: all-lib
>
> I'm not sure about this change. $(python_libspec) is to link an embedded
> python, e.g., it includes -lpython itself. I'm not sure this would work
> everywhere, since the module will be loaded by a python interpreter, so
> you could get conflicts. Does this correspond to what the current "gmake
> all" gives you?

Oops, I let a Cygwin-ism creep into the mainline source. I should have
put the change into src/makefiles/Makefile.win instead. See the first
attachment for this patch.

Also, I needed to patch your latest version of newmakefile to append
SHLIB_LINK instead of overwriting it. See the second attachment for
this patch.

To test the above, I needed to run make as follows:

$ make -f newmakefile python_includespec='-I$(python_includedir)'

grep-ing for python_includespec in the latest src/Makefile.global.in
came up empty:

$ fgrep python_includespec src/Makefile.global.in
$

Is python_includespec a new construct that is currently only in your CVS
working directory?

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com