From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: What (not) to do in signal handlers |
Date: | 2001-06-14 17:51:16 |
Message-ID: | 200106141751.f5EHpGn13841@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> I notice that the signal handlers in postmaster.c do quite a lot of work,
> much more than what they teach you in school they should do. While
> fprintf, elog, and ctime may simply lead to annoyances, forking off the
> WAL helper processes seems to be quite a lot.
>
> ISTM that most of these, esp. pmdie(), can be written more like the SIGHUP
> handler, i.e., set a global variable and evaluate right after the
> select(). This would at least give me a better feeling when I send "Fast
> Shutdown request at %s" etc. through elog(), which is what they should do
> for consistent message formatting.
Agreed. If we don't loop around to check the variable soon we have
bigger problems that the signal handlers.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2001-06-14 17:51:28 | Re: Removal of temp tables |
Previous Message | Tom Lane | 2001-06-14 17:42:26 | Re: Doing authentication in backend |