From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: SEP_CHAR |
Date: | 2001-05-23 15:48:31 |
Message-ID: | 200105231548.f4NFmVV12616@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Bruce Momjian writes:
> >> I see some use of SEP_CHAR for '/' in the source. Do we want to use it
> >> consistenly, or not use it at all? I can make the change.
>
> > I vote for not at all, since there is not at all a use for it.
>
> If it's not actually needed for the Cygwin port, I'd vote for taking it
> out. It adds clutter to the sources, to no purpose. Also, even if you
> fix it to be used consistently *every* place it should be, how long will
> it stay that way? Seems practically unmaintainable to me.
I see it used by psql and pg_dump and I will leave them alone, assuming
/ is not hardeded elsewhere in that code.
Actually, it is:
sprintf(psqlrc, "%s/.psqlrc", home);
so it seems NT handles '/' anyway.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2001-05-23 15:52:32 | Re: |
Previous Message | Bruce Momjian | 2001-05-23 15:40:20 | Re: SEP_CHAR |