Re: psql shell problem

On Mon, May 21, 2001 at 03:38:08PM -0400, Tom Lane wrote:
> "Denis A. Doroshenko" <d(dot)doroshenko(at)omnitel(dot)net> writes:
> > if you change the history a
> > bit (btw, it will look _more logical_), then history will be ok with
> > the very same vanilla OS (that is no additional readline library).
>
> You've now asserted that three times, without ever once giving the
> details of what it is you claim would be an improvement.

Sorry Tom, i've been sending it to pgsql-general a while ago (at times
of 7.0.2). it's not a problem to do it again. the patch would look
like

--- ./src/bin/psql/input.h.orig Tue May 22 08:54:43 2001
+++ ./src/bin/psql/input.h Tue May 22 08:55:00 2001
@@ -25,12 +25,11 @@
#endif

#if defined(HAVE_HISTORY_FUNCTIONS)
+#define USE_HISTORY 1
#if defined(HAVE_READLINE_HISTORY_H)
#include <readline/history.h>
-#define USE_HISTORY 1
#elif defined(HAVE_HISTORY_H)
#include <history.h>
-#define USE_HISTORY 1
#endif
#endif

as you can see i define USE_HISTORY whenever we have HAVE_HISTORY_FUNCTIONS
defined. isn't that logical, to use history when configure found history
functions? OpenBSD does not have readline/history.h nor it has
history.h, so with vanilla PostgreSQL (up to 7.1.1) we get psql with
no history support. Eh, then psql loses half of its functionality ;-)

--
Denis A. Doroshenko [GPRS/IN/WAP, VAS group engineer] .-. _|_ |
[Omnitel Ltd., T.Sevcenkos st. 25, Vilnius, Lithuania] | | _ _ _ .| _ |
[Phone: +370 9863486 E-mail: d(dot)doroshenko(at)omnitel(dot)net] |_|| | || |||(/_|_