Re: patch for configure for enabling of pl/tcl unknown support

> Bruce Momjian writes:
>
> >
> > Patch applied. I added a mention to installation.sgml too. Autoconf
> > run.
> >
> > <varlistentry>
> > <term>--with-pltcl-unknown</term>
> > <listitem>
> > <para>
> > Enables enables PL/Tcl unknown support.
> > </para>
> > </listitem>
> > </varlistentry>
>
> Should be --enable-pltcl-unknown.

Done, change made, docs updated, autoconf run.

>
> >
> >
> >
> > > This patch adds a new configure option --with-pltcl-unknown which
> > > enables pltcl unknown support.
> > >
> > >
> > > Also it adds substituting of tclsh with tclsh that was by configure in
> > > pltcl_*mod scripts. For example, On freebsd, tclsh can be called tclsh8.2 or
> > > tclsh8.3 depending on installed version of Tcl.
> > >
> > > After patching files
> > > src/pl/tcl/modules/pltcl_listmod
> > > src/pl/tcl/modules/pltcl_loadmod
> > > src/pl/tcl/modules/pltcl_delmod
> > > must be renamed(copied,repocopied) to
> > > src/pl/tcl/modules/pltcl_listmod.in
> > > src/pl/tcl/modules/pltcl_loadmod.in
> > > src/pl/tcl/modules/pltcl_delmod.in
> > >
> > >
> > > Index: configure.in
> > > ===================================================================
> > > RCS file: /home/src/pgsql/repo/pgsql/configure.in,v
> > > retrieving revision 1.106
> > > diff -u -r1.106 configure.in
> > > --- configure.in 2001/03/05 10:18:47 1.106
> > > +++ configure.in 2001/03/07 21:32:45
> > > @@ -359,6 +359,16 @@
> > > AC_MSG_RESULT([$with_tcl])
> > > AC_SUBST([with_tcl])
> > >
> > > +# If Tcl is enabled (above) then check for pltcl_unknown_support
> > > +AC_MSG_CHECKING([whether to build with pl/tcl unknown support])
> > > +if test "$with_tcl" = yes; then
> > > + PGAC_ARG_BOOL(with, pltcl_unknown, no, [ --with-pltcl-unknown build pl/tcl unknown support if Tcl is enabled])
> > > +else
> > > + with_pltcl_unknown=no
> > > +fi
> > > +AC_MSG_RESULT([$with_pltcl_unknown])
> > > +AC_SUBST([with_pltcl_unknown])
> > > +
> > > # If Tcl is enabled (above) then Tk is also, unless the user disables it using --without-tk
> > > AC_MSG_CHECKING([whether to build with Tk])
> > > if test "$with_tcl" = yes; then
> > > @@ -1172,6 +1182,9 @@
> > > src/GNUmakefile
> > > src/Makefile.global
> > > src/backend/port/Makefile
> > > + src/pl/tcl/modules/pltcl_listmod
> > > + src/pl/tcl/modules/pltcl_loadmod
> > > + src/pl/tcl/modules/pltcl_delmod
> > > ],
> > > [
> > > # Update timestamp for config.h (see Makefile.global)
> > > Index: src/Makefile.global.in
> > > ===================================================================
> > > RCS file: /home/src/pgsql/repo/pgsql/src/Makefile.global.in,v
> > > retrieving revision 1.122
> > > diff -u -r1.122 Makefile.global.in
> > > --- src/Makefile.global.in 2001/03/05 09:39:51 1.122
> > > +++ src/Makefile.global.in 2001/03/07 20:55:39
> > > @@ -111,6 +111,7 @@
> > > with_perl = @with_perl@
> > > with_python = @with_python@
> > > with_tcl = @with_tcl@
> > > +with_pltcl_unknown = @with_pltcl_unknown@
> > > with_tk = @with_tk@
> > > enable_odbc = @enable_odbc@
> > > MULTIBYTE = @MULTIBYTE@
> > > Index: src/pl/tcl/Makefile
> > > ===================================================================
> > > RCS file: /home/src/pgsql/repo/pgsql/src/pl/tcl/Makefile,v
> > > retrieving revision 1.26
> > > diff -u -r1.26 Makefile
> > > --- src/pl/tcl/Makefile 2000/12/15 18:50:35 1.26
> > > +++ src/pl/tcl/Makefile 2001/03/07 21:21:26
> > > @@ -70,8 +70,9 @@
> > > # first of all calls to the call handler. See the doc in the modules
> > > # directory about details.
> > >
> > > -#override CPPFLAGS+= -DPLTCL_UNKNOWN_SUPPORT
> > > -
> > > +ifeq ($(with_pltcl_unknown), yes)
> > > +override CPPFLAGS+= -DPLTCL_UNKNOWN_SUPPORT
> > > +endif
> > >
> > > #
> > > # DLOBJS is the dynamically-loaded object file.
> > > @@ -98,6 +99,16 @@
> > >
> > > install: all installdirs
> > > $(INSTALL_SHLIB) $(DLOBJS) $(DESTDIR)$(libdir)/$(DLOBJS)
> > > +ifeq ($(with_pltcl_unknown), yes)
> > > + $(INSTALL_SCRIPT) modules/pltcl_loadmod \
> > > + $(DESTDIR)$(bindir)/pltcl_loadmod
> > > + $(INSTALL_SCRIPT) modules/pltcl_delmod \
> > > + $(DESTDIR)$(bindir)/pltcl_delmod
> > > + $(INSTALL_SCRIPT) modules/pltcl_listmod \
> > > + $(DESTDIR)$(bindir)/pltcl_listmod
> > > + $(INSTALL_DATA) modules/unknown.pltcl \
> > > + $(DESTDIR)$(datadir)/unknown.pltcl
> > > +endif
> > >
> > > installdirs:
> > > $(mkinstalldirs) $(DESTDIR)$(libdir)
> > > @@ -117,4 +128,4 @@
> > > $(SHELL) $< '$(TCL_CONFIG_SH)' '$@'
> > >
> > > clean distclean maintainer-clean:
> > > - rm -f $(INFILES) pltcl.o Makefile.tcldefs
> > > + rm -f $(INFILES) pltcl.o Makefile.tcldefs modules/pltcl_listmod modules/pltcl_loadmod modules/pltcl_delmod
> > > Index: src/pl/tcl/modules/pltcl_delmod
> > > ===================================================================
> > > RCS file: /home/src/pgsql/repo/pgsql/src/pl/tcl/modules/pltcl_delmod,v
> > > retrieving revision 1.1
> > > diff -u -r1.1 pltcl_delmod
> > > --- src/pl/tcl/modules/pltcl_delmod 1998/02/11 14:14:15 1.1
> > > +++ src/pl/tcl/modules/pltcl_delmod 2001/03/07 21:42:04
> > > @@ -1,6 +1,6 @@
> > > #!/bin/sh
> > > # Start tclsh \
> > > -exec tclsh "$0" $@
> > > +exec @TCLSH@ "$0" $@
> > >
> > > #
> > > # Code still has to be documented
> > > Index: src/pl/tcl/modules/pltcl_listmod
> > > ===================================================================
> > > RCS file: /home/src/pgsql/repo/pgsql/src/pl/tcl/modules/pltcl_listmod,v
> > > retrieving revision 1.1
> > > diff -u -r1.1 pltcl_listmod
> > > --- src/pl/tcl/modules/pltcl_listmod 1998/02/11 14:14:16 1.1
> > > +++ src/pl/tcl/modules/pltcl_listmod 2001/03/07 21:42:14
> > > @@ -1,6 +1,6 @@
> > > #!/bin/sh
> > > # Start tclsh \
> > > -exec tclsh "$0" $@
> > > +exec @TCLSH@ "$0" $@
> > >
> > > #
> > > # Code still has to be documented
> > > Index: src/pl/tcl/modules/pltcl_loadmod
> > > ===================================================================
> > > RCS file: /home/src/pgsql/repo/pgsql/src/pl/tcl/modules/pltcl_loadmod,v
> > > retrieving revision 1.2
> > > diff -u -r1.2 pltcl_loadmod
> > > --- src/pl/tcl/modules/pltcl_loadmod 2001/03/07 16:09:09 1.2
> > > +++ src/pl/tcl/modules/pltcl_loadmod 2001/03/07 21:42:24
> > > @@ -1,6 +1,6 @@
> > > #!/bin/sh
> > > # Start tclsh \
> > > -exec tclsh "$0" $@
> > > +exec @TCLSH@ "$0" $@
> > >
> > > #
> > > # Code still has to be documented
> > >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 6: Have you searched our list archives?
> > >
> > > http://www.postgresql.org/search.mpl
> > >
> >
> >
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026