Re: patch for BETWEEN [ASYMMETRIC|SYMMETRIC]

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Robert B(dot) Easter" <reaster(at)comptechnews(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: patch for BETWEEN [ASYMMETRIC|SYMMETRIC]
Date: 2001-05-07 22:11:09
Message-ID: 200105072211.f47MB9W04148@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


OK, patch rejected.

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Can someone comment on where we left this?
>
> The grammar patch is incorrect/incomplete as given (no keywords.c
> entries, no additions to the TokenId list), unless you quoted only
> part of it.
>
> More generally, I hate to see us yet again doing a quick shortcut that
> loses information. BETWEEN really ought to be a 3-operand function or
> special expression node type, so that it (a) can be reverse-listed
> sensibly, and (b) doesn't result in multiple evaluations of its inputs.
>
> regards, tom lane
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-05-07 23:37:16 Re: JDBC int8 hack
Previous Message Tom Lane 2001-05-07 21:41:22 Re: Re: [GENERAL] Strange notices, should I worry?