From: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> |
---|---|
To: | peter_e(at)gmx(dot)net |
Cc: | dhageman(at)dracken(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [PATCHES] Fix for psql core dumping on bad user |
Date: | 2001-04-19 01:40:07 |
Message-ID: | 20010419104007J.t-ishii@sra.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
> D. Hageman writes:
>
> > The postgresql interactive terminal will dump core on any script that is
> > run via the -f command line option if their exists a connect line without
> > a valid user. An example connect line is in one of the attached files.
>
> Okay, I've found the problem. When the connection fails, psql momentarily
> runs without a valid database connection. When it does that, the
> multibyte encoding has the invalid value -1. (You need to compile with
> multibyte enabled to reproduce this.) With that value, PQmblen() has
> trouble when it parses the next line. Perhaps PQmblen() should simply
> return 1 when it is passed an invalid encoding. In any case it should do
> better than dump core.
Will fix. Also I will change the "invalid" encoding to a
default i.e. SQL_ASCII, not -1.
--
Tatsuo Ishii
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2001-04-19 01:40:28 | Re: Re: No printable 7.1 docs? |
Previous Message | Bruce Momjian | 2001-04-19 01:39:39 | Re: timeout on lock feature |
From | Date | Subject | |
---|---|---|---|
Next Message | D. Hageman | 2001-04-19 05:07:31 | Re: Fix for psql core dumping on bad user |
Previous Message | Peter Eisentraut | 2001-04-18 17:22:08 | Re: [PATCHES] Fix for psql core dumping on bad user |