Re: Possible explanation for readline configuration problems

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, andrea gelmini <bungle(at)linux(dot)it>, Kevin Heflin <kheflin(at)shreve(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Possible explanation for readline configuration problems
Date: 2001-04-14 03:43:53
Message-ID: 200104140343.XAA05807@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> We've gotten several different reports lately of peculiar compilation
> errors and warnings involving readline in 7.1. They look like configure
> is actively doing the wrong thing --- for example, how could we see
> reports like this:
>
> tab-complete.c:734: `filename_completion_function' undeclared (first use in this function)
> tab-complete.c:734: (Each undeclared identifier is reported only once
> tab-complete.c:734: for each function it appears in.)
>
> when the code makes a point of providing a declaration for
> filename_completion_function if configure didn't see it in the headers?
>
> After eyeballing the code I think I have a theory. psql/input.h will
> preferentially include <readline/readline.h>, not <readline.h>, if both
> HAVE_READLINE_READLINE_H and HAVE_READLINE_H are defined. But the tests
> in configure make the opposite choice! Maybe the people who are having
> trouble have two different versions of readline header files visible at
> those two names, leading to configure's results being wrong for the
> header file that input.h actually selects?

This sounds like an excellent guess. Hard to imagine how readline has
gotten such a bizarre list of configurations.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-04-14 03:52:32 Re: Possible explanation for readline configuration problems
Previous Message Mark Butler 2001-04-14 03:37:17 Re: Postmaster fatal defect - False alarm