From: | Fred Yankowski <fred(at)ontosys(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org |
Subject: | Re: patch for minor Win32 makefile bug |
Date: | 2001-04-02 16:36:16 |
Message-ID: | 20010402113616.A63439@enteract.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches pgsql-ports |
You may be right, if I understand you, that the exact value of DLLLIBS
that was in backend/Makefile should be used in makefiles/Makefile.win.
Should I submit a new patch to that effect?
On Sun, Apr 01, 2001 at 11:23:54PM -0400, Tom Lane wrote:
> Fred Yankowski <fcy(at)acm(dot)org> writes:
> > While working on a patch that allows postmaster to run as an NT service
> > with Cygwin, I found minor problem in backend/Makefile. In order to add
> > an additional library to the final link/build of postgres.exe, I changed
> > the DLLLIBS variable in makefiles/Makefile.win. But this change had no
> > effect until I removed the line in backend/Makefile that also sets
> > DLLLIB, hiding the value from Makefile.win.
>
> Hm. Clearly we should have only one definition, so I've applied your
> patch. But if the one in backend/Makefile was the controlling one,
> shouldn't we make the entry in makefiles/Makefile.win match what was
> in Makefile? Seems like that is the value that's been tested so far.
--
Fred Yankowski fred(at)OntoSys(dot)com tel: +1.630.879.1312
Principal Consultant www.OntoSys.com fax: +1.630.879.1370
OntoSys, Inc 38W242 Deerpath Rd, Batavia, IL 60510, USA
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2001-04-02 17:14:51 | Re: patch for minor Win32 makefile bug |
Previous Message | Tom Lane | 2001-04-02 03:23:54 | Re: patch for minor Win32 makefile bug |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2001-04-02 17:14:51 | Re: patch for minor Win32 makefile bug |
Previous Message | Tom Lane | 2001-04-02 03:23:54 | Re: patch for minor Win32 makefile bug |