From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL odbc list <pgsql-odbc(at)postgresql(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Cleanup of ODBC |
Date: | 2001-03-28 16:07:22 |
Message-ID: | 200103281607.LAA24186@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-odbc pgsql-patches |
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I am working to clean up the comments in ODBC, and remove some blank
> > lines that make no sense being there. This will not affect the code in
> > any way. I should commit in a few hours.
>
> Is it really appropriate to be doing this sort of work post-RC1?
> I see no gain and a nontrivial risk that you will break something
> without knowing it (and without providing adequate time to test it).
>
> It's bad enough to be running pgindent at this late stage of the cycle,
> but at least pgindent is automated and relatively unlikely to make
> errors. Massive hand edits are another story.
>
> In short: save it for 7.2.
OK, but will people complain if I make comment changes in 7.2 and mess
up their patches and the 7.1 patches people submit?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2001-03-28 16:14:56 | Re: Cleanup of ODBC |
Previous Message | Tom Lane | 2001-03-28 16:06:26 | Re: Cleanup of ODBC |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2001-03-28 16:14:56 | Re: Cleanup of ODBC |
Previous Message | Tom Lane | 2001-03-28 16:06:26 | Re: Cleanup of ODBC |