Re: pgindent run?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent run?
Date: 2001-03-22 05:17:22
Message-ID: 200103220517.AAA15343@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > The problem is that the small ones don't apply cleanly if they don't
> > match the indenting in the source.
>
> but ... if they are small, manually merging isn't that big of a deal ...
> and if anyone else has been working in that code since release, there is a
> chance it won't mergef cleanly ...

Yes, they can be manually merged, but that is much more error-prone than
pgindent itself, at least with me patching them. :-)

Yes, I agree there is a risk. I was quite scared the first time I ran
it on the tree and did the commit. At this point, there are very few
changes to it, so I feel a little better, and the stuff gets caught
somehow if there is a problem.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Philip Warner 2001-03-22 05:19:38 Re: More on elog and error codes
Previous Message The Hermit Hacker 2001-03-22 05:14:16 Re: pgindent run?

Browse pgsql-patches by date

  From Date Subject
Next Message Alfred Perlstein 2001-03-22 07:21:03 Re: pgindent run?
Previous Message The Hermit Hacker 2001-03-22 05:14:16 Re: pgindent run?