Re: new version of contrib-intarray

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, scrappy(at)hub(dot)org
Subject: Re: new version of contrib-intarray
Date: 2001-03-19 16:14:22
Message-ID: 200103191614.LAA14106@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sorry, I have again messed up this Makefile, and I am glad Tom has put
things back.

Seems I am no longer capable of understanding the affects of such
changes as this:

! override CPPFLAGS := -I$(srcdir) $(CPPFLAGS) -DPGSQL71

! override CPPFLAGS += -I$(srcdir) -DPGSQL71

Having $(srcdir) before $(CPPFLAGS) must be significant.

I am going to make a proposal that we partition off certain areas to be
handled by certain people so I don't mess things up again. Look for my
email in a few minutes.

Bruce Momjian writes:
>
> > I see change of += in CFLAGS (harmless),
>
> Not.
>
> > movement of #include
> > <postgres.h>, and removal of // comments, which don't appear anymore in
> > the code.
>
> I only saw that the Makefile is back to how it looked at rev 1.1 before I
> did some work on it. AFAICT the Makefile should be reverted back to the
> previous revision, since the code change does not require any changes to
> the Makefile.
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-03-19 16:28:24 Re: Performance monitor signal handler
Previous Message Bruce Momjian 2001-03-19 16:09:45 Re: Performance monitor signal handler