From: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> |
---|---|
To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
Cc: | lockhart(at)alumni(dot)caltech(dot)edu, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Do we still need PowerPC-specific timestamp_is_current/epoch? |
Date: | 2001-03-13 08:50:46 |
Message-ID: | 20010313175046U.t-ishii@sra.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
> > After further research, I remembered that we used to have "DB_MIN
> > check" in configure back to 6.4.2:
> > I don't know wht it was removed,
>
> Hmm. Digging in the CVS logs shows that it was removed by Bruce in
> configure.in version 1.262, 1999/07/18, with the unedifying log message
> "configure cleanup".
>
> A guess is that he took it out because it wasn't being used anywhere.
>
> > but I think we'd better to revive the checking and replace
> > #if defined(linux) && defined(__powerpc__)
> > with
> > #ifdef HAVE_DBL_MIN_PROBLEM
> > What do you think?
>
> I think that is a bad idea, since that code is guaranteed to fail on any
> machine where the representation of double is at all different from a
> PPC's. (Even if you are willing to assume that the entire world uses
> IEEE floats these days, what of endianness?)
>
> We could revive the configure test and do
>
> #if defined(HAVE_DBL_MIN_PROBLEM) && defined(__powerpc__)
>
> However, I really wonder whether there is any point. It may be worth
> noting that the original version of the patch read "#if ... defined(PPC)".
> It's quite likely that the current test, "... defined(__powerpc__)",
> doesn't even fire on the old compiler that the patch is intended for.
> If so, this is dead code and has been since release 6.5.
Ok, let's remove the code in datetime.c and see anybody would come up
and complain...
--
Tatsuo Ishii
From | Date | Subject | |
---|---|---|---|
Next Message | Denis Perchine | 2001-03-13 10:06:48 | Re: Performance monitor |
Previous Message | Frank Joerdens | 2001-03-13 08:11:15 | Re: TOAST |