From: | Tom Lane <tgl(at)hub(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql/src/backend/utils/mb mbutils.c wchar.c |
Date: | 2001-03-08 00:24:34 |
Message-ID: | 200103080024.f280OY040850@hub.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
CVSROOT: /home/projects/pgsql/cvsroot
Module name: pgsql
Changes by: tgl(at)hub(dot)org 01/03/07 19:24:34
Modified files:
src/backend/utils/mb: mbutils.c wchar.c
Log message:
Modify wchar conversion routines to not fetch the next byte past the end
of a counted input string. Marinos Yannikos' recent crash report turns
out to be due to applying pg_ascii2wchar_with_len to a TEXT object that
is smack up against the end of memory. This is the second just-barely-
reproducible bug report I have seen that traces to some bit of code
fetching one more byte than it is allowed to. Let's be more careful
out there, boys and girls.
While at it, I changed the code to not risk a similar crash when there
is a truncated multibyte character at the end of an input string. The
output in this case might not be the most reasonable output possible;
if anyone wants to improve it further, step right up...
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2001-03-08 01:49:02 | pgsql/src/backend/optimizer/util clauses.c |
Previous Message | Tom Lane | 2001-03-07 21:20:27 | pgsql/src/backend access/gist/gist.c access/ha ... |