Re: patch: contrib/pgcrypto sanity

On Mon, Jan 08, 2001 at 04:06:09AM +0200, Marko Kreen wrote:
> On Sun, Jan 07, 2001 at 08:09:07PM -0500, Tom Lane wrote:
> > Marko Kreen <marko(at)l-t(dot)ee> writes:
> > > Which basically changes u_int*_t -> uint*_t, so now it does not
> > > compile neither under Debian 2.2 nor under NetBSD 1.5 which
> > > is platform independent¸ all right.
> >
> > Well, that's annoying. I guess those platforms are out of step with the
> > C99 standard, which specifies uint*_t not u_int*_t (cf. C99 7.4.1.1).
> > I agree with your solution of switching to Postgres-supplied typenames.
>
> Well, actually they do. glibc in <stdint.h> and NetBSD in
> <sys/inttypes.h> which is a mess, all rigth. Problem is that
> postgres.h does not know about this. I guess that C99 forgot
> to specify _where_ they should be defined.

Correction, they both have <inttypes.h> which probably is the
right location for this.

> > > * adds back KAME Id, because KAME is the master repository
> >
> > Is that a good idea? If we are deliberately deviating from whatever
> > "master repository" this is, I'm not sure that we should continue to
> > label the code with their revision ID.
>
> I think it is. I think they are more competent on maintaining
> crypto than PostgreSQL team (at least they devote more time on
> it). This makes tracking changes easier. This (special Id's)
> are widely used practice in BSD's, this makes clear whether a
> file is 'original' or 'imported'; and from where.

The "master" only means that occasionally somebody (e.g. I) can
check if their revision is increased and then can merge changes
into our sources, if needed. Also _I_ know where I got these
sources but this makes it easier for others too.

--
marko