Re: pgsql/src/backend/utils/adt (oid.c)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: tgl(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src/backend/utils/adt (oid.c)
Date: 2000-11-22 03:59:26
Message-ID: 200011220359.WAA14536@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Can I assume this TODO item is now done?

* Make oid use unsigned int more reliably, pg_atoi()

> Date: Monday, November 20, 2000 @ 22:23:19
> Author: tgl
>
> Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/utils/adt
> from hub.org:/home/projects/pgsql/tmp/cvs-serv86997/src/backend/utils/adt
>
> Modified Files:
> oid.c
>
> ----------------------------- Log Message -----------------------------
>
> Make oidin/oidout produce and consume unsigned representation of Oid,
> rather than just being aliases for int4in/int4out. Give type Oid a
> full set of comparison operators that do proper unsigned comparison,
> instead of reusing the int4 comparators. Since pg_dump is now doing
> unsigned comparisons of OIDs, it is now *necessary* that we play by
> the rules here. In fact, given that btoidcmp() has been doing unsigned
> comparison for quite some time, it seems likely that we have index-
> corruption problems in 7.0 and before once the Oid counter goes past
> 2G. Fixing these operators is a necessary step before we can think
> about 8-byte Oid, too.
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2000-11-22 05:07:23 Re: pgsql/src/backend/utils/adt (oid.c)
Previous Message momjian 2000-11-22 03:40:23 pgsql/src/include/libpq (pqcomm.h)

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-11-22 05:07:23 Re: pgsql/src/backend/utils/adt (oid.c)
Previous Message Mitch Vincent 2000-11-22 03:12:33 Re: Crash during WAL recovery?