Re: Re: UUNET socket-file-location patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: UUNET socket-file-location patch
Date: 2000-11-16 05:18:48
Message-ID: 200011160518.AAA26912@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Tom Lane writes:
> >>>> and make "/tmp" the default in guc.c.
> >>
> >> No, because this has to work on the client side too. The default path
> >> *must* be determined at compile time, or clients and servers will be
> >> unable to find each other.
>
> > The only difference between your snippet and mine is that yours sets the
> > default to "" and interprets it as "/tmp" when it is used, whereas mine
> > sets the default to "/tmp" to begin with. Clients don't see the
> > difference.
>
> Clients that don't contain guc.c are going to see a difference, no?
> Where are they getting the default from?

Good point. This macro is called by the backend, and the libpq frontend
code. We would have to push the /tmp default into libpq code too, which
seems messier.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message momjian 2000-11-16 05:50:01 pgsql/src/backend/utils/misc (guc-file.l)
Previous Message Tom Lane 2000-11-16 04:49:41 Re: pgsql/src/backend/commands (dbcommands.c)

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2000-11-16 05:28:21 Re: 486 Optimizations...
Previous Message Philip Warner 2000-11-16 05:16:26 Re: Coping with 'C' vs 'newC' function language namesh