Re: Re: ps and psql from PostgreSQL not working with cygwin-1.1.5-2

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: cygwin(at)sources(dot)redhat(dot)com
Cc: pgsql-ports(at)postgresql(dot)org
Subject: Re: Re: ps and psql from PostgreSQL not working with cygwin-1.1.5-2
Date: 2000-11-03 21:08:00
Message-ID: 20001103160800.A523@dothill.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-ports

On Thu, Nov 02, 2000 at 12:26:34PM -0500, Jason Tishler wrote:
> On Tue, Oct 31, 2000 at 11:48:31AM -0500, Christopher Faylor wrote:
> > I can't duplicate the ps problem and I don't use psql.exe so, unless someone
> > can debug this, or provide more details, this will be a problem that is in
> > 1.1.5.
>
> Either of the two attached patches will solve the 1.1.5 psql.exe problem.
> I think that the first one is more correct and the second one safer (i.e.,
> less likely to break other code).

After more research, I realize that both of the above patches are wrong.
Sorry for the gyrations but I went into frenzy mode due to the impending
1.1.5 release (which if I remember correctly was suppose to be
yesterday)... I was also thrown off by Cygwin's strerror(EAGAIN)
returning "No more processes" instead of "Resource temporarily
unavailable" as on other UNIXes (at least Solaris and RedHat 6.2 Linux).

Anyway, I now think that PostgreSQL's psql should be changed to deal
with the possibility of errno equal to EAGAIN when connect() returns -1.
See attached patch for details.

Does anyone else concur?

Thanks,
Jason

P.S. From reading the MSDN, it appears that Win32 psql should be checking
for WSAEWOULDBLOCK too...

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corporation Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

Attachment Content-Type Size
Cygwin-1.1.5-PosgreSQL-7.0.2.patch text/plain 462 bytes

In response to

Responses

Browse pgsql-ports by date

  From Date Subject
Next Message lbottorff 2000-11-03 22:26:11 Errors building Postgres on NT
Previous Message Bob Love 2000-11-03 00:04:37 RE: Compiling postgresql on WinNT