pgsql/src/interfaces/jdbc/org/postgresql/jdbc1 (Connection.java DatabaseMetaData.java Statement.java)

From: Bruce Momjian - CVS <momjian>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql/src/interfaces/jdbc/org/postgresql/jdbc1 (Connection.java DatabaseMetaData.java Statement.java)
Date: 2000-10-08 19:37:55
Message-ID: 200010081937.e98Jbtk45200@hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Date: Sunday, October 8, 2000 @ 15:37:54
Author: momjian

Update of /home/projects/pgsql/cvsroot/pgsql/src/interfaces/jdbc/org/postgresql/jdbc1
from hub.org:/home/projects/pgsql/tmp/cvs-serv45182/pgsql/src/interfaces/jdbc/org/postgresql/jdbc1

Modified Files:
Connection.java DatabaseMetaData.java Statement.java

----------------------------- Log Message -----------------------------

Okay, I have some new code in place that hopefully should work better. I
couldn't produce a full patch using cvs diff -c this time since I have
created new files and anonymous cvs usage doesn't allow you to
adds. I'm supplying the modified src/interfaces/jdbc as a tarball at :
http://www.candleweb.no/~gunnar/projects/pgsql/postgres-jdbc-2000-10-05.tgz

The new files that should be added are :

? org/postgresql/PGStatement.java
? org/postgresql/ObjectPool.java
? org/postgresql/ObjectPoolFactory.java

There is now a global static pool of free byte arrays and used byte arrays
connected to a statement object. This is the role of the new PGStatement
class. Access to the global free array is synchronized, while we rely on
the PG_Stream synchronization for the used array.

My measurements show that the perfomance boost on this code is not quite as
big as my last shot, but it is still an improvement. Maybe some of the
difference is due to the new synchronization on the global array. I think I
will look into choosing between on a connection level and global level.

I have also started experimented with improving the performance of the
various conversions. The problem here is ofcourse related handle the
various encodings. One thing I found to speed up ResultSet.getInt() a lot
was to do custom conversion on the byte array into int instead of going
through the getString() to do the conversion. But I'm unsure if this is
portable, can we assume that a digit never can be represented by more than
one byte ? It works fine in my iso-latin-8859-1 environment, but what about
other environments ? Maybe we could provide different ResultSet
implementations depending on the encoding used or delegate some methods of
the result set to an "converter class".

Check the org/postgresql/jdbc2/FastResultSet.java in the tarball above to
see the modified getInt() method.

Regards,

Gunnar

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian - CVS 2000-10-08 19:37:56 pgsql/src/interfaces/jdbc/org/postgresql/jdbc2 (Connection.java DatabaseMetaData.java Statement.java)
Previous Message Bruce Momjian - CVS 2000-10-08 19:37:54 pgsql/src/interfaces/jdbc/org/postgresql (ObjectPool.java ObjectPoolFactory.java PGStatement.java Connection.java Field.java PG_Stream.java)