Re: Minor patch to C++ large object interface (cures two ills)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Adam Haberlach <adam(at)newsnipple(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Minor patch to C++ large object interface (cures two ills)
Date: 2000-09-25 12:53:02
Message-ID: 200009251253.IAA03311@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

First, I need context diffs, diff -c. Second, does the END cause
problems in cases where Close() is called more than once? For example,
Close is called as part of PgLargeObject::Open.

> For quite some time, the C++ large object interface has been getting
> away with not declaring transactions, Looks like nobody noticed that
> it wasn't getting away with it since 6.5.
>
> Also, it seems to have had a definition for the mythical
> PgLargeObject::::LOid() function, but never seemed to have an
> implementation.
>
> (forgive me if this isn't a correct patch format. Pretty minor, in
> any case)
>
>
> socket:cvs diff pglobject.cc
> Index: pglobject.cc
> ===================================================================
> RCS file: /home/projects/pgsql/cvsroot/pgsql/src/interfaces/libpq++/pglobject.cc,v
> retrieving revision 1.6
> diff -r1.6 pglobject.cc
> 58a59
> > Exec("END");
> 67a69
> > Exec("BEGIN");
> 149a152,155
> > Oid PgLargeObject::LOid()
> > {
> > return pgObject;
> > }
>
>
> --
> Adam Haberlach | A billion hours ago, human life appeared on
> adam(at)newsnipple(dot)com | earth. A billion minutes ago, Christianity
> http://www.newsnipple.com | emerged. A billion Coca-Colas ago was
> '88 EX500 | yesterday morning. -1996 Coca-Cola Ann. Rpt.
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2000-09-25 12:53:57 Re: oracle compatible func.
Previous Message Bruce Momjian 2000-09-25 12:45:02 Re: Fix for FK not finding columns when PK is defined