Re: xlog.c.patch for cygwin port.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: yutaka tanida <yutaka(at)marin(dot)or(dot)jp>
Cc: Alexei Zakharov <A(dot)S(dot)Zakharov(at)inp(dot)nsk(dot)su>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: xlog.c.patch for cygwin port.
Date: 2000-06-09 16:04:10
Message-ID: 200006091604.MAA00441@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

We have resolved all the O_BINARY calls for 7.1. Thanks.

> On Mon, 6 Mar 2000 12:06:27 +0600
> "Alexei Zakharov" <A(dot)S(dot)Zakharov(at)inp(dot)nsk(dot)su> wrote:
>
> > I suggest a following patch. BTW the situation appeared before,
> > see hba.c, pqcomm.c and others.
>
> I propose another patch, against src/include/port/win.h.
> If this patch is applied, #ifdef with open() such as following is no
> more needed.
>
> --
> #ifndef __CYGWIN__
> fd=open(path,flags,mode);
> #else
> fd=open(path,flags | O_BINARY,mode);
> #endif

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2000-06-09 16:52:33 Re: freefuncs.c is never called from anywhere!?]
Previous Message Bruce Momjian 2000-06-09 16:03:17 Re: xlog.c.patch for cygwin port.