From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: DROP COLUMN status |
Date: | 2000-06-08 15:41:43 |
Message-ID: | 200006081541.LAA01566@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
> > The implementation makes the dropped column invisible by
> > changing its attnum to -attnum - offset(currently 20) and
> > attnam to ("*already Dropped%d",attnum).
>
> Ugh. No wonder you had to hack so many places in such an ugly fashion.
> Why not leave the attnum as-is, and just add a bool saying "column is
> dropped" to pg_attribute? As long as the parser ignores columns marked
> that way for field lookup and expansion of *, it seems the rest of the
> system wouldn't need to treat dropped columns specially in any way.
If we leave it as positive, don't we have to change user applications
that query pg_attribute so they also know to skip it?
--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2000-06-08 15:47:23 | Re: Proposal: TRUNCATE TABLE table RESTRICT |
Previous Message | Bruce Momjian | 2000-06-08 15:17:22 | Re: AW: Look at heap_beginscan() |