Re: Last call for comments: fmgr rewrite [LONG]

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Chris Bitmead <chrisb(at)nimrod(dot)itg(dot)telstra(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Last call for comments: fmgr rewrite [LONG]
Date: 2000-05-22 04:18:20
Message-ID: 200005220418.AAA12026@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Tom Lane wrote:
>
> > No, because we aren't ever going to be dynamically allocating these
> > things; they'll be local variables in the calling function.
>
> Fair enough then. Although that being the case, I don't see the big deal
> about using a few more bytes of stack space which costs absolutely
> nothing, even though the binary compatibility is a small but still real
> advantage.

I like Tom's clean design better. Flexibility for little payback
usually just messes up clarity of the code.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-05-22 04:19:45 Logging (was Re: PostgreSQL 7.0-2 RPMset released.)
Previous Message Michael A. Olson 2000-05-22 04:09:27 Re: Berkeley DB...