From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | "Kevin P(dot) Neal" <kpneal(at)pobox(dot)com>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: Minimal patches for PostgreSQL 7.0b3 on NetBSD/alpha 1.4.1.... |
Date: | 2000-04-12 16:26:11 |
Message-ID: | 200004121626.MAA23996@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Yes, we can't apply this at this stage of the game. Just too many
port-specific changes.
[Charset iso-8859-1 unsupported, filtering to ASCII...]
> On Tue, 11 Apr 2000, Kevin P. Neal wrote:
>
> > Here are minimal patches to get 7.0 beta 3 limping along on NetBSD/alpha
> > release 1.4.1.
>
> *** ./old/src/include/storage/s_lock.h Wed Jan 26 00:58:33 2000
> --- ./new/src/include/storage/s_lock.h Sun Apr 9 23:56:46 2000
> ***************
> *** 260,270 ****
> --- 260,275 ----
> #else /* i.e. not __osf__ */
>
> #define TAS(lock) tas(lock)
> #define S_UNLOCK(lock) { __asm__("mb"); *(lock) = 0; }
>
> + #if defined(__GNUC__)
> + static int /* GCC on the Alpha doesn't appear to handle
> + inlining of assembly with %0 or %1 properly.
> */
> + #else
> static __inline__ int
> + #endif
> tas(volatile slock_t *lock)
> {
> register slock_t _res;
>
> __asm__(" ldq $0, %0 \n\
>
>
> Any chance you could write a configure test that exposes this deficiency
> rather than assuming that every GCC on every Alpha now and in the future
> will have it? What does "doesn't appear to handle properly" mean anyway?
> Have you notified the GCC maintainers?
>
> Also, whose idea was it to use '__inline__' instead of 'inline'?
>
> --
> Peter Eisentraut Sernanders v_g 10:115
> peter_e(at)gmx(dot)net 75262 Uppsala
> http://yi.org/peter-e/ Sweden
>
>
--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2000-04-12 18:35:04 | Re: Minimal patches for PostgreSQL 7.0b3 on NetBSD/alpha 1.4.1.... |
Previous Message | Oleg Broytmann | 2000-04-12 13:39:34 | Re: |