From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] freefuncs.c is never called from anywhere!? |
Date: | 2000-01-30 03:18:09 |
Message-ID: | 200001300318.WAA18832@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> I was rather bemused to discover just now that the node-freeing
> functions in nodes/freefuncs.c are never called from anywhere;
> in fact, the module hasn't got a single exported entry point!
>
> (I expect that freeObject() is supposed to be an external entry
> point; perhaps it got demoted to a static during one of Bruce's
> periodic get-rid-of-unreferenced-global-symbols passes.)
>
> So much for all that tedious labor to maintain the freeXXX functions
> every time we update a node type ;-)
Are you sure about this? I thought these things were called from
macros.
However, I can't find any macro that uses this like makeNode does with
its pasteing. I would perhaps move it to a _deadcode directory and see
what happens. Or should we enable it?
--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2000-01-30 03:49:19 | Re: [HACKERS] freefuncs.c is never called from anywhere!? |
Previous Message | Hiroshi Inoue | 2000-01-30 03:14:55 | RE: [HACKERS] Sure enough, SI buffer overrun is broken |