Refusing patches

I have noticed some people are complaining about patches being applied.
I feel this is very discouraging to the people who submit them.

I apply patches as soon as I seem them, assuming they look OK. We
always have the ability to back them out later.

What I am seeing is people voting for people to reverse out patches
without giving the patch submitter a chance to address any concerns. I
think we owe our patch submitters the dignity of having a chance to
respond to criticism of the patches before anyone suggests yanking a
patch.

I have rejected patches in the past, but I usually tell the person what
I don't like about the patch, and encourage them to resubmit the patch
with the suggested changes.

Sometime, I even apply the patch, but tell the submitter they have to
give me the fixes I requested. If they don't arrive in a few days, then
I reverse out the patch. Sometimes it is easier for people to fix what
they have already done than to submit a totally new patch.

Of course, this is all my personal opinion.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026