Re: [HACKERS] libpq+MB/putenv(), getenv() clean up

> Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
> > I have a plan to clean up the usage of putenv(), getenv() in libpq+MB
> > configuration. This needs some interface changes with libpq in the
> > frontend side. I'm not sure this is visible to end users or not, and I
> > would like to hear from hackes.
>
> I think it is a very good idea to remove getenv() from PQmblen().
> getenv() is rather slow, at least on the machines I use, and having
> to do it for each character processed is a huge performance hit.

Yikes, we are calling it for every character. I think it munges through
the entire process environment space looking for a value.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026