Re: Built-in CTYPE provider

From: "Daniel Verite" <daniel(at)manitou-mail(dot)org>
To: "Noah Misch" <noah(at)leadboat(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Jeremy Schneider <schneider(at)ardentperf(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Built-in CTYPE provider
Date: 2024-07-18 11:29:27
Message-ID: 1f9a910d-c9d1-4bb0-bb96-788bb00ce599@manitou-mail.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch wrote:

> If I'm counting the votes right, you and Tom have voted that the feature's
> current state is okay, and I and Laurenz have voted that it's not okay. I
> still hope more people will vote, to avoid dealing with the tie. Daniel,
> Peter, and Jeremy, you're all listed as reviewers on commit f69319f. Are
> you
> willing to vote one way or the other on the question in
> https://postgr.es/m/20240706195129.fd@rfd.leadboat.com?

For me, the current state is okay.

In the mentioned question, you're doing this:

v17 can simulate the Unicode aspect of a v18 upgrade, like this:
sed -i 's/^UNICODE_VERSION.*/UNICODE_VERSION = 16.0.0/'
src/Makefile.global.in

to force a Unicode upgrade. But a packager could do the same
to force a Unicode downgrade, if they wanted.

Therefore I don't agree with this summary in
<20240711125040(dot)11(dot)nmisch(at)google(dot)com>:

> | ICU collations | pg_c_utf8
> ----------------------------------|-------------------|----------
> Corruption within a major version | packager's choice | no
> Corruption at pg_upgrade time | packager's choice | yes

Best regards,
--
Daniel Vérité
https://postgresql.verite.pro/
Twitter: @DanielVerite

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Anthonin Bonnefoy 2024-07-18 11:37:40 Correctly propagate queryId for utility stmt in function
Previous Message Aleksander Alekseev 2024-07-18 11:24:23 [PATCH] Add crc32(text) & crc32(bytea)