Re: RFC: ALTER SYSTEM [...] COMMENT

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RFC: ALTER SYSTEM [...] COMMENT
Date: 2017-04-26 17:37:48
Message-ID: 1f197213-c571-4550-b807-6710f90a5419@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/26/2017 10:31 AM, Tom Lane wrote:
> "Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
>> I wouldn't fight hard to change it but really if we think about it, what
>> makes more sense from usability perspective?
>
>> CREATE TABLE foo() COMMENT IS
>
> I think it's likely to be impossible to shoehorn such a thing into every
> type of CREATE command without making COMMENT a fully reserved word,
> which is going to be a very hard sell.

Well if it is a complete uphill battle, this is certainly not the
feature that I am going to dig my heels in about.

>
>> 2. Make it so comments are appended not replaced.
>
> Backwards compatibility fail ... not to mention that you haven't offered
> an argument as to why everyone would think this is an improvement.

"Everyone" is a bit of a stretch for every single feature we have.

I would think that most people that work with production systems would
like to know the history of any object modification.

Thanks,

jD

>
> regards, tom lane
>

--
Command Prompt, Inc. http://the.postgres.company/
+1-503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Everyone appreciates your honesty, until you are honest with them.
Unless otherwise stated, opinions are my own.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-04-26 17:48:13 Re: Concurrent ALTER SEQUENCE RESTART Regression
Previous Message Tom Lane 2017-04-26 17:37:09 Re: RFC: ALTER SYSTEM [...] COMMENT