| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add privileges test for pg_stat_statements to improve coverage |
| Date: | 2024-07-23 18:27:15 |
| Message-ID: | 1f117e31-1667-4c1b-892a-849779c6cb94@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/07/23 15:02, kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp wrote:
> Hi Fujii-san,
> Thank you for your comment!
>
> attach v5 fixed patch.
>
>> Using "postgres" as the default superuser name can cause instability.
>> This is why the Patch Tester reports now test failures again.
>> You should create and use a different superuser, such as
>> "regress_stats_superuser."
>
> I understand.
> Add "regress_stats_superuser" for test by superuser.
Thanks for updating the patch!
I've slightly modified the comments in the regression tests for clarity.
Attached is the v6 patch. If there are no objections,
I will push this version.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-pg_stat_statements-Add-regression-test-for-privil.patch | text/plain | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marcos Pegoraro | 2024-07-23 18:35:13 | Useless toast |
| Previous Message | Heikki Linnakangas | 2024-07-23 17:32:29 | Re: Direct SSL connection and ALPN loose ends |