Re: Minimal logical decoding on standbys

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minimal logical decoding on standbys
Date: 2023-04-03 18:17:19
Message-ID: 1eac8fdd-8e5e-7420-b984-b0bf634e2f29@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 4/3/23 8:10 AM, Drouvot, Bertrand wrote:
> Hi,
>
> On 4/3/23 7:35 AM, Amit Kapila wrote:
>> On Mon, Apr 3, 2023 at 4:26 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>>
>> Agreed, even Bertrand and myself discussed the same approach few
>> emails above. BTW, if we have this selective logic to wake
>> physical/logical walsenders and for standby's, we only wake logical
>> walsenders at the time of  ApplyWalRecord() then do we need the new
>> conditional variable enhancement being discussed, and if so, why?
>>
>
> Thank you both for this new idea and discussion. In that case I don't think
> we need the new CV API and the use of a CV anymore. As just said up-thread I'll submit
> a new proposal with this new approach.
>

Please find enclosed V57 implementing the new approach in 0004. With the new approach in place
the TAP tests (0005) work like a charm (no delay and even after a promotion).

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v57-0006-Doc-changes-describing-details-about-logical-dec.patch text/plain 2.2 KB
v57-0005-New-TAP-test-for-logical-decoding-on-standby.patch text/plain 32.8 KB
v57-0004-Fixing-Walsender-corner-case-with-logical-decodi.patch text/plain 7.8 KB
v57-0003-Allow-logical-decoding-on-standby.patch text/plain 12.0 KB
v57-0002-Arrange-for-a-new-pg_stat_database_conflicts-and.patch text/plain 10.4 KB
v57-0001-Handle-logical-slot-conflicts-on-standby.patch text/plain 28.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-04-03 18:43:14 Re: Should vacuum process config file reload more often
Previous Message Tom Lane 2023-04-03 18:10:39 Re: [Proposal] Add foreign-server health checks infrastructure