From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: Revert back to standard AC_STRUCT_TIMEZONE Autoconf macro |
Date: | 2019-10-07 14:55:58 |
Message-ID: | 1e1c9b83-baa5-085c-84bf-9f1d8877645a@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019-10-02 07:30, Peter Eisentraut wrote:
> On 2019-09-30 21:36, Tom Lane wrote:
>> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>>> Instead of AC_STRUCT_TIMEZONE we use our own variant called
>>> PGAC_STRUCT_TIMEZONE that checks for tzname even if other variants were
>>> found first. But since 63bd0db12199c5df043e1dea0f2b574f622b3a4c we
>>> don't use tzname anymore, so we don't need this anymore.
>>
>> Hmm. I wonder if we need AC_STRUCT_TIMEZONE either? Seems like
>> we should only be using our own struct pg_tm.
>
> There are a few places that seem to need it, such as initdb/findtimezone.c.
>
>> If we could get
>> rid of that configure macro altogether, we could remove some dubious
>> junk like plpython.h's "#undef HAVE_TZNAME".
>
> We could keep just the part of AC_STRUCT_TIMEZONE that we need, namely
> the check for tm_zone, and remove the part about tzname.
>
> New patch attached.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2019-10-07 15:02:37 | Re: Transparent Data Encryption (TDE) and encrypted files |
Previous Message | Robert Haas | 2019-10-07 14:44:47 | Re: How to retain lesser paths at add_path()? |