| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove remnants of "snapshot too old" |
| Date: | 2024-12-04 07:55:43 |
| Message-ID: | 1da96706-d6ac-4891-9a60-326c3dc68dd3@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/12/2024 03:24, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On 2024-12-03 22:06:59 +0200, Heikki Linnakangas wrote:
>>> I spotted some more remnants of the "snapshot too old" feature that was
>>> removed in v17. Barring objections, I will commit the attached patch to tidy
>>> up.
>
>> Most of this I agree with. But I'm not sure just removing the toast snapshot
>> stuff is good - we've had a bunch of bugs where we don't hold a snapshot for
>> long enough to actually ensure that toast tuples stay alive.
>
> Yeah, the stuff concerned with toast snapshots has nothing to do
> with that old user-visible feature. It's to keep us from writing
> incorrect code, and it's still (very) needed.
Right. Here's a new attempt that keeps that check.
--
Heikki Linnakangas
Neon (https://neon.tech)
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-remants-of-snapshot-too-old.patch | text/x-patch | 14.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | postgresql_contributors | 2024-12-04 08:07:15 | Guidance Needed for Testing PostgreSQL Patch (CF-5044) |
| Previous Message | Andrey M. Borodin | 2024-12-04 07:46:57 | Re: Sort functions with specialized comparators |