| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Make tuple deformation faster |
| Date: | 2025-03-04 19:48:54 |
| Message-ID: | 1d5805cd960c15e076405e91099d77f8e42066d5.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2024-10-10 at 02:59 +1300, David Rowley wrote:
> > A few weeks ago David and I discussed this patch. We were curious
> > *why* the
> > flags approach was slower.
...
> > Could it make sense to use bitfields instead of flag values, to
> > reduce the
> > impact?
>
> Yeah. That's a good idea.
I happened to run into the code and was surprised to see a strongly-
worded comment about the size of CompactAttribute, but then also see
independent booleans rather than flags or bitfields.
Did the discussion end here, or was there some kind of conclusion? Is
it worth adding a comment about why we use independent booleans, even
if we don't have a complete answer?
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-03-04 19:50:43 | Re: Parallel CREATE INDEX for GIN indexes |
| Previous Message | Heikki Linnakangas | 2025-03-04 19:48:37 | Re: Rename some signal and interrupt handling functions for consistency |