Re: pgrowlocks relkind check

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgrowlocks relkind check
Date: 2017-06-13 01:10:41
Message-ID: 1d3356fa-dd46-0ead-e3ae-6b42692fcac6@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/06/13 0:29, Peter Eisentraut wrote:
> On 4/24/17 21:22, Amit Langote wrote:
>> Hi Stephen,
>>
>> On 2017/04/11 22:17, Stephen Frost wrote:
>>>> create extension pgrowlocks;
>>>> create view one as select 1;
>>>> select pgrowlocks('one');
>>>> -- ERROR: could not open file "base/68730/68748": No such file or directory
>>>>
>>>> With the attached patch:
>>>>
>>>> select pgrowlocks('one');
>>>> ERROR: "one" is not a table, index, materialized view, sequence, or TOAST
>>>> table
>>>
>>> Good point.
>>>
>>> Thanks, I'll see about committing this shortly.
>>
>> Should I add this to the next commitfest (not an open item per se) or will
>> you be committing it?
>
> What is happening with this?

FWIW, patch seems simple enough to be committed into 10, unless I am
missing something.

Rebased one attached.

Thanks,
Amit

Attachment Content-Type Size
0001-Add-relkind-check-to-pgrowlocks.patch text/plain 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-06-13 01:26:11 Re: PostgreSQL 10 changes in exclusion constraints - did something change? CASE WHEN behavior oddity
Previous Message Tom Lane 2017-06-13 01:03:31 Re: PostgreSQL 10 changes in exclusion constraints - did something change? CASE WHEN behavior oddity