From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Michael Harris <harmic(at)gmail(dot)com> |
Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, postgres(at)jeltef(dot)nl, ilya(dot)evdokimov(at)tantorlabs(dot)com |
Subject: | Re: ANALYZE ONLY |
Date: | 2024-09-10 12:03:40 |
Message-ID: | 1d02e28bdca5ef7364be0e9c7282b8df@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2024-09-09 16:56, Michael Harris wrote:
Thanks for updating the patch.
Here is a minor comment.
> @@ -944,20 +948,32 @@ expand_vacuum_rel(VacuumRelation *vrel,
> MemoryContext vac_context,
> MemoryContextSwitchTo(oldcontext);
> }
..
> + * Unless the user has specified ONLY, make relation list
> entries for
> + * its partitions and/or descendant tables.
Regarding the addition of partition descendant tables, should we also
update the below comment on expand_vacuum_rel? Currently it refers only
partitions:
| * Given a VacuumRelation, fill in the table OID if it wasn't
specified,
| * and optionally add VacuumRelations for partitions of the table.
Other than this and the following, it looks good to me.
On Mon, Sep 9, 2024 at 10:27 AM David Rowley <dgrowleyml(at)gmail(dot)com>
wrote:
> Aside from those, that just leaves me with the behavioural change. I
> noted Tom was ok with the change in behaviour for ANALYZE (mentioned
> in [1]). Tom, wondering if you feel the same for VACUUM too? If we're
> doing this, I think we'd need to be quite clear about it on the
> release notes.
--
Regards,
--
Atsushi Torikoshi
NTT DATA Group Corporation
From | Date | Subject | |
---|---|---|---|
Next Message | Shayon Mukherjee | 2024-09-10 12:15:19 | Re: Proposal to Enable/Disable Index using ALTER INDEX |
Previous Message | David Rowley | 2024-09-10 12:02:34 | Re: Proposal to Enable/Disable Index using ALTER INDEX |