From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Tim McNamara <tim(at)mcnamara(dot)nz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: New developer papercut - Makefile references INSTALL |
Date: | 2022-01-18 16:05:36 |
Message-ID: | 1ce1430e-1f1b-32da-b6c9-9b63153c51d9@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 18.01.22 16:51, Daniel Gustafsson wrote:
>> On 17 Jan 2022, at 13:26, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 17 Jan 2022, at 11:25, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>
>>> That said, I'm not sure we're actually gaining anything by *not*
>>> referring to the website as well. TBH, I bet the majority of users
>>> will actually prefer to read them there. So I'd suggest always
>>> including the reference to the website as well, per the suggestion
>>> from Tim.
>>
>> Fair point, I'll go ahead and do that in a bit unless anyone objects.
>
> I plan on applying the attached which address the feedback given.
The indentation of the two INSTRUCTIONS= lines uses a different mix of
tabs and spaces, so it looks a bit weird depending on how you view it.
It's also a bit strange that the single quotes are part of the value of
$INSTRUCTIONS rather than part of the fixed text.
The URL links to the "devel" version of the installation instructions,
which will not remain appropriate after release. I don't know how to
fix that without creating an additional maintenance point. Since
README.git already contains that link, I would leave off the web site
business and just make the change of the dynamically chosen file name.
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2022-01-18 16:05:46 | Re: Pluggable toaster |
Previous Message | Daniel Gustafsson | 2022-01-18 15:51:09 | Re: New developer papercut - Makefile references INSTALL |