| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove objname/objargs split for referring to objects |
| Date: | 2017-03-17 03:13:06 |
| Message-ID: | 1c4460ad-b35d-0129-12fc-2ecc1f8d1d3f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 3/16/17 11:56, Alvaro Herrera wrote:
> Michael Paquier wrote:
>
>> What are you using as CFLAGS? As both typenames should be normally
>> set, what about initializing those fields with NULL and add an
>> assertion like the attached?
>
> Actually, my compiler was right -- this was an ancient bug I introduced
> in 9.5 (commit a61fd533), and this new warning was my compiler being a
> bit smarter now for some reason. The problem is we were trying to
> extract String value from a TypeName node, which obviously doesn't work
> very well.
>
> I pushed a real fix, not just a compiler-silencer, along with a few
> lines in object_address.sql to make sure it works properly. Maybe we
> need a few more tests cases for other parts of pg_get_object_address.
>
> Pushed fix, backpatched to 9.5.
I am now seeing the warnings that Michael was reporting *after* your
commit in 9.5 and 9.6.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-17 03:37:06 | Re: pgsql: Avoid having vacuum set reltuples to 0 on non-empty relations in |
| Previous Message | Robert Haas | 2017-03-17 00:30:09 | pgsql: Fix grammar. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-03-17 03:23:27 | Re: possible encoding issues with libxml2 functions |
| Previous Message | David Rowley | 2017-03-17 02:59:15 | Re: multivariate statistics (v25) |