Re: Insufficient memory access checks in pglz_decompress

From: Flavien GUEDEZ <flav(dot)pg(at)oopacity(dot)net>
To: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Insufficient memory access checks in pglz_decompress
Date: 2023-10-19 07:05:17
Message-ID: 1c198c85-92c5-4b2f-bcfb-05376d89ba09@oopacity.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Le 19/10/2023 à 02:48, Tom Lane a écrit :
> I thought of another thing we should change: it's better to perform
> the test as "off > (dp - dest)" than the way you formulated it.
> "dp - dest" is certainly computable, since it's the number of bytes
> we've written to the output buffer so far. But "dp - off" could,
> with bad luck and a buffer near the start of memory, wrap around
> to look like it's after "dest".
>
> Pushed with that change and a little fiddling with the comment.
> Thanks for the report!
>
> regards, tom lane
Thank you for the details !
Best,
Flavien

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Dennis Brouwer 2023-10-19 12:07:56 Re: group by true now errors with non-integer constant in GROUP BY
Previous Message Aleš Zelený 2023-10-19 06:43:43 Re: Invalid dump file after drop of role that previously created extension containing a table.