| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | rir <rirans(at)comcast(dot)net>, pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: small patch |
| Date: | 2021-10-04 06:18:22 |
| Message-ID: | 1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Fri, 2021-10-01 at 21:06 -0400, rir wrote:
> Minor changes to move.sgml and fetch.sgml.
>
> The text 'or empty' is inconsistent by restating what the
> synopsis notation has expressed.
>
> The comments on sharing a language feature, while
> likely helpful during review, seem verbose compared to
> the non-commenting in other similar files.
Thanks for the effort of preparing a patch.
However, I don't think that is an improvement:
- the comments pointing from MOVE to FETCH and vice versa are
helpful for people who edit the documentation like you did
- we should retain "empty or one of", otherwise the following syntax
would be undocumented:
FETCH FROM c;
Yours,
Laurenz Albe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Doc comments form | 2021-10-04 13:13:49 | Number of GiST support functions |
| Previous Message | PG Doc comments form | 2021-10-02 13:09:01 | GiST indexes appear no longer rely on the first column |