Re: pgsql: Enable TAP tests of pg_receivewal for ZLIB on Windows, take thre

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Enable TAP tests of pg_receivewal for ZLIB on Windows, take thre
Date: 2021-07-31 11:16:22
Message-ID: 1bd8310a-68d7-8952-8b09-1ab06f2c75b0@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 7/30/21 9:28 PM, Michael Paquier wrote:
> Enable TAP tests of pg_receivewal for ZLIB on Windows, take three
>
> This reverts commit 6a2c532. fairywren and bowerbird failed those tests
> because of incorrect versions of ZLIB linked to, causing errors like
> SIGBREAKs that stopped buildfarm runs or EACCES failures when writing
> compressed WAL segments.
>
> Andrew Dunstan has done all the investigation here, so he deserves all
> the credit for being able to enable those tests on Windows.
>

And now jacana is unhappy. I'll get it fixed shortly. If it ends up that
we have somehow found a situation where Msys/Mingw and MSVC can no
longer share a zlib implementation I'm going to be unhappy too.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2021-07-31 11:27:52 pgsql: Remove redundant setting of pg_attribute.attcompression
Previous Message Dean Rasheed 2021-07-31 10:35:43 pgsql: Fix corner-case errors and loss of precision in numeric_power().