| From: | Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Defer selection of asynchronous subplans until the executor initialization stage |
| Date: | 2021-05-11 07:06:05 |
| Message-ID: | 1ba0b595-6961-f23f-15f8-9f3758e8bd47@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/5/21 08:55, Zhihong Yu wrote:
> + /* Check to see if subplan can be executed asynchronously */
> + if (subplan->async_capable)
> + {
> + subplan->async_capable = false;
>
> It seems the if statement is not needed: you can directly assign false
> to subplan->async_capable.Thank you, I agree with you.
Close look into the postgres_fdw regression tests show at least one open
problem with this approach: we need to control situations when only one
partition doesn't pruned and append isn't exist at all.
--
regards,
Andrey Lepikhov
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2021-05-11 07:24:53 | Re: Asynchronous Append on postgres_fdw nodes. |
| Previous Message | houzj.fnst@fujitsu.com | 2021-05-11 06:58:17 | RE: [bug?] Missed parallel safety checks, and wrong parallel safety |