Re: cataloguing NOT NULL constraints

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, exclusion(at)gmail(dot)com, dean(dot)a(dot)rasheed(at)gmail(dot)com, andrewbille(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Subject: Re: cataloguing NOT NULL constraints
Date: 2024-05-15 12:37:48
Message-ID: 1b70dca9-117e-4176-83b3-b9859d7fa692@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15.05.24 09:50, Alvaro Herrera wrote:
> On 2024-May-14, Bruce Momjian wrote:
>
>> Turns out these commits generated a single release note item, which I
>> have now removed with the attached committed patch.
>
> Hmm, but the commits about not-null constraints for domains were not
> reverted, only the ones for constraints on relations. I think the
> release notes don't properly address the ones on domains. I think it's
> at least these two commits:
>
>> -Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
>> -2024-03-20 [e5da0fe3c] Catalog domain not-null constraints
>> -Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
>> -2024-04-15 [9895b35cb] Fix ALTER DOMAIN NOT NULL syntax

I'm confused that these were kept. The first one was specifically to
make the catalog representation of domain not-null constraints
consistent with table not-null constraints. But the table part was
reverted, so now the domain constraints are inconsistent again.

The second one refers to the first one, but it might also fix some
additional older issue, so it would need more investigation.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2024-05-15 13:13:14 Re: First draft of PG 17 release notes
Previous Message Daniel Gustafsson 2024-05-15 12:34:21 Re: </replaceable> in parentesis is not usual on DOCs