Re: [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True

From: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True
Date: 2022-02-02 08:16:20
Message-ID: 1b4db143-3410-54c2-bb91-1242ae430bcd@cmatte.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

> This should definitely be fixed.

Thanks!

>> By default, subscriber_access is set to False and there is no way to modify that within the web interface.
>> As a consequence, access to lists on private servers is restricted to superusers, and there is no easier way to modify that than to edit the database manually.
>>
>> It seems more logical to me that this value be set to True by default, as access can still be moderated to avoid lists being publicly available.
>
> In what way would access "still be moderated"? In pgarchives, that's a
> pure boolean and there are no further checks. User accounts are
> auto-created.

I meant that subscriptions can still be moderated in pglister (if lists are configured that way), so that anybody does not have access to archives.

> The idea is that anything that's "open" should have to be set
> explicitly and thus we should default to it being off. Based on that I
> have at least initially applied a version of your patch that sets it
> to false.

That makes sense.

>> That said, it may be better to have a way to modify that within the web interface in pglister.
>
> I agree in principle. The argument does fall off a bit on the fact
> that there is *no* admin interface to pgarchives. You don't have a way
> to add a list manually either, without doing it directly in SQL. So we
> either accept that SQL is the way things are done, or we should tackle
> the bigger problem of setting up such an interface. But I think we
> could get pretty far by just enabling the general django admin
> interface and set up the required classes for that -- we don't
> necessarily need to move things like reparsing and hiding of messages
> into such an admin interface.

I meant this could be added in the admin interface of pglister, not pgarchives, as it already exists and pglister_sync can then push (and update) the configuration to pgarchives.

--
Célestin Matte

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Célestin Matte 2022-02-02 08:29:36 Re: [PATCH] pgarchives: Bugfix: missing ids in pglister_sync
Previous Message Magnus Hagander 2022-01-30 12:32:29 Re: [PATCH] pgarchives: Bugfix: missing ids in pglister_sync